gaoran10 commented on code in PR #19538:
URL: https://github.com/apache/pulsar/pull/19538#discussion_r1121283975
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/web/PulsarWebResource.java:
##########
@@ -718,10 +730,17 @@ public CompletableFuture<Void>
validateBundleOwnershipAsync(NamespaceBundle bund
if (!owned) {
boolean newAuthoritative =
this.isLeaderBroker();
// Replace the host and port of the
current request and redirect
- URI redirect =
UriBuilder.fromUri(uri.getRequestUri()).host(webUrl.get().getHost())
-
.port(webUrl.get().getPort()).replaceQueryParam("authoritative",
-
newAuthoritative).replaceQueryParam("destinationBroker",
- null).build();
+ UriBuilder builder =
UriBuilder.fromUri(uri.getRequestUri())
+ .host(webUrl.get().getHost())
+ .port(webUrl.get().getPort())
+
.replaceQueryParam("authoritative", newAuthoritative);
+ if (destinationBroker.isPresent()
+ &&
ExtensibleLoadManagerImpl.isLoadManagerExtensionEnabled(config())) {
Review Comment:
I'm not sure why need to add param `destinationBroker`, if enable
loadManagerExtension the validation already finish at line 646.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
