tisonkun commented on code in PR #19632:
URL: https://github.com/apache/pulsar/pull/19632#discussion_r1121378661


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -956,13 +956,18 @@ public CompletableFuture<Optional<Topic>> getTopic(final 
String topic, boolean c
 
     public CompletableFuture<Optional<Topic>> getTopic(final String topic, 
boolean createIfMissing,
                                                        Map<String, String> 
properties) {
+        return getTopic(TopicName.get(topic), createIfMissing, properties);
+    }
+
+    public CompletableFuture<Optional<Topic>> getTopic(final TopicName 
topicName, boolean createIfMissing,

Review Comment:
   @nodece may you talk a bit detail how this change fixes the issue? And if a 
similar issue is in the master branch.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to