eolivelli commented on code in PR #19670:
URL: https://github.com/apache/pulsar/pull/19670#discussion_r1121530222


##########
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConnection.java:
##########
@@ -401,18 +400,21 @@ private void handleBrokerConnected(DirectProxyHandler 
directProxyHandler, Comman
     }
 
     private void connectToBroker(InetSocketAddress brokerAddress) {
-        checkState(ctx.executor().inEventLoop(), "This method should be called 
in the event loop");
+        assert ctx.executor().inEventLoop();

Review Comment:
   "assert" is not enabled in production
   I am not sure that we enable Java assertion in tests



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to