shibd commented on code in PR #963: URL: https://github.com/apache/pulsar-client-go/pull/963#discussion_r1121813300
########## pulsar/client_impl.go: ########## @@ -30,10 +30,12 @@ import ( ) const ( - defaultConnectionTimeout = 10 * time.Second - defaultOperationTimeout = 30 * time.Second - defaultKeepAliveInterval = 30 * time.Second - defaultMemoryLimitBytes = 64 * 1024 * 1024 + defaultConnectionTimeout = 10 * time.Second + defaultOperationTimeout = 30 * time.Second + defaultKeepAliveInterval = 30 * time.Second + defaultMemoryLimitBytes = 64 * 1024 * 1024 + defaultConnectionMaxIdleTime = 60 * time.Second Review Comment: Refer [java impl](https://github.com/apache/pulsar/blob/0f72a822dd8aa21fa3d86bb6f62ea4482fc3b907/pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ClientConfigurationData.java#L128-L133), the defaults connection max idle time should be 180s -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
