teabot commented on code in PR #412: URL: https://github.com/apache/pulsar-site/pull/412#discussion_r1126239862
########## docs/cookbooks-retention-expiry.md: ########## @@ -473,3 +479,6 @@ The diagram below illustrates one of the cases that the consumed storage size is  If you do not have any retention period and you never have much of a backlog, the upper limit for retained messages, which are acknowledged, equals the Pulsar segment rollover period + entry log rollover period + (garbage collection interval * garbage collection ratios). + +[backlogquotacheckintervalinseconds]: https://pulsar.apache.org/reference/#/next/config/reference-configuration-broker?id=backlogquotacheckintervalinseconds +[precisetimebasedbacklogquotacheck]: https://pulsar.apache.org/reference/#/next/config/reference-configuration-broker?id=precisetimebasedbacklogquotacheck Review Comment: I disagree with this practice. It may be easier for authors, but it's really difficult for readers to find what they need. The target page has 100s of elements, is nested, is not searchable, and is not sorted. I see in your suggestion that you still provide context to the reader "see **Configuration > Plusar > Broker**" — doesn't this too suffer from the same issues of maintenance and errors, while also being less useful by not being encoded in the link? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
