[GitHub] [pulsar] mattisonchao opened a new pull request, #19748: [fix][metadata] Fix notification thread block causes double owner.

[via GitHub]

mattisonchao opened a new pull request, #19748:
URL: https://github.com/apache/pulsar/pull/19748

   ### Motivation
   
   This is a namespace bundle double-owners problem. I found it in the memory 
dumps.
   
   The memory dumps show that the notification thread has been blocked for a 
long time. And many notifications are blocked in the executor queue. This 
causes we can't to revalidate all the locks, and they are still thinking them 
working well.
   
   <img width="1061" alt="image" 
src="https://user-images.githubusercontent.com/74767115/223670419-c4319f44-f1e1-4361-8c79-04c7f0dabe3c.png";>
   ^^ blocked thread
   
   <img width="949" alt="image" 
src="https://user-images.githubusercontent.com/74767115/223672000-fb4ce22c-6a45-4cb6-9d23-c36e3afbc93a.png";>
   
   ^^ executor queue
   
   
   ### Modifications
   
   - I added timeout protection to the `CompletableFuture#get` method.
   - Split `revalidate` to `revalidateOnce` and `revalidate` methods to make it 
understandable easily.
   - Give up the lock in memory when we revalidate timeout to ensure the final 
consensus.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   ### Documentation
   
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org