Demogorgon314 commented on code in PR #19622: URL: https://github.com/apache/pulsar/pull/19622#discussion_r1130449381
########## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/manager/SplitManager.java: ########## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.broker.loadbalance.extensions.manager; + +import static org.apache.pulsar.broker.loadbalance.extensions.models.SplitDecision.Label.Failure; +import static org.apache.pulsar.broker.loadbalance.extensions.models.SplitDecision.Reason.Unknown; +import java.util.Map; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.TimeUnit; +import lombok.extern.slf4j.Slf4j; +import org.apache.pulsar.broker.loadbalance.extensions.channel.ServiceUnitState; +import org.apache.pulsar.broker.loadbalance.extensions.channel.ServiceUnitStateData; +import org.apache.pulsar.broker.loadbalance.extensions.models.SplitCounter; +import org.apache.pulsar.broker.loadbalance.extensions.models.SplitDecision; + +/** + * Split manager. + */ +@Slf4j +public class SplitManager implements StateChangeListener { + + record InFlightSplitRequest(SplitDecision splitDecision, CompletableFuture<Void> future) { + } + + private final Map<String, InFlightSplitRequest> inFlightSplitRequests; + + private final SplitCounter counter; + + public SplitManager(SplitCounter splitCounter) { + this.inFlightSplitRequests = new ConcurrentHashMap<>(); + this.counter = splitCounter; + } + + private void complete(String serviceUnit, Throwable ex) { + inFlightSplitRequests.computeIfPresent(serviceUnit, (__, inFlightSplitRequest) -> { + var future = inFlightSplitRequest.future; + if (!future.isDone()) { + if (ex != null) { + future.completeExceptionally(ex); + } else { + future.complete(null); + } + } + return null; + }); + } + + public CompletableFuture<Void> waitAsync(CompletableFuture<Void> eventPubFuture, + String bundle, + SplitDecision decision, + long timeout, + TimeUnit timeoutUnit) { + return eventPubFuture + .thenCompose(__ -> inFlightSplitRequests.computeIfAbsent(bundle, ignore -> { + log.info("Published the bundle split event for bundle:{}. " + + "Waiting the split event to complete. Timeout: {} {}", + bundle, timeout, timeoutUnit); + CompletableFuture<Void> future = new CompletableFuture<>(); + future.orTimeout(timeout, timeoutUnit).whenComplete((v, ex) -> { + if (ex != null) { + inFlightSplitRequests.remove(bundle); + log.warn("Timed out while waiting for the bundle split event: {}", bundle, ex); + } + }); + return new InFlightSplitRequest(decision, future); Review Comment: Now we don't need `InFlightSplitRequest` obj right? Since we already pass the decision in `whenComplete` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
