poorbarcode commented on PR #19751:
URL: https://github.com/apache/pulsar/pull/19751#issuecomment-1461730009
> If it is guaranteed that the maximum does not exceed 10, then you should
use < instead of =
#### Expected behavior
Reduce the number of buckets to less than 10 by `buckets-merge` if there
have too many buckets.
#### Actual behavior
Because of these two conditions, task `buckets-merge` may be skipped (the
task `buckets-merge` will be retried when `tracker.addMessage` is executed
again):
- the last persistention of the bucket has not finished.
- all buckets are full.
So we should change logic `{actual number of buckets} == 10` to `{actual
number of buckets} >= 10`, but the modified check is meaningless, so delete it
directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
