heesung-sn commented on code in PR #19730:
URL: https://github.com/apache/pulsar/pull/19730#discussion_r1131555345
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/store/TableViewLoadDataStoreImpl.java:
##########
@@ -61,30 +70,58 @@ public CompletableFuture<Void> removeAsync(String key) {
@Override
public Optional<T> get(String key) {
+ validateTableViewStart();
Review Comment:
When ExtensibleLoadManager.start() and playLeader() are complete, then
topBundlesLoadStore.validateTableViewStart() should never fail from the leader
broker(from UnloadScheduler).
Currently, follower brokers should never access
topBundlesLoadDataStore.tableview, and if they do, we should throw an exception
in this case instead of re-initializing the tableView(followers don't run
UnloadScheduler).
I also moved the UnloadScheduler.start()/close() logic into the playLeader()
and playFollower().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
