Shohou opened a new issue, #350:
URL: https://github.com/apache/pulsar-helm-chart/issues/350

   **Describe the bug**
   I found that changing `PULSAR_MEM` variable for bookkeeper which can be 
found in `values.yaml` file doesn't change memory params of bookie at least for 
pulsar v2.9.4
   Some investigation shows that in version 2.6.x `bin/pulsar` script had this 
line
   ```
   OPTS="$OPTS $PULSAR_EXTRA_OPTS $PULSAR_MEM $PULSAR_GC"
   ```
   from version 2.7.x till 2.9.x it has this:
   ```
   if [ $COMMAND == "bookie" ]; then
     # Pass BOOKIE_EXTRA_OPTS option defined in bkenv.sh
     OPTS="$OPTS $BOOKIE_EXTRA_OPTS"
   else
     OPTS="$OPTS $PULSAR_EXTRA_OPTS $PULSAR_MEM $PULSAR_GC"
   fi
   ```
   and versions 2.10.x - 2.11.x has this:
   ```
   if [ $COMMAND == "bookie" ]; then
     # Pass BOOKIE_EXTRA_OPTS option defined in bkenv.sh
     OPTS="$OPTS $BOOKIE_MEM $BOOKIE_GC $BOOKIE_GC_LOG $BOOKIE_EXTRA_OPTS"
   else
     OPTS="$OPTS $PULSAR_MEM $PULSAR_GC $PULSAR_GC_LOG $PULSAR_EXTRA_OPTS"
   fi
   ```
   
   I think it could be changed to BOOKIE_MEM with some comment about earlier 
versions
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to