gaoran10 commented on code in PR #19730:
URL: https://github.com/apache/pulsar/pull/19730#discussion_r1133392909
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/store/TableViewLoadDataStoreImpl.java:
##########
@@ -61,30 +70,58 @@ public CompletableFuture<Void> removeAsync(String key) {
@Override
public Optional<T> get(String key) {
+ validateTableViewStart();
Review Comment:
Thanks for your explanation.
Obviously, if everything is initialized correctly without an error, it's OK,
but you caught exceptions while starting topBundlesLoadDataStore before.
> However, lazy-init(tableview.start ) in validateTableViewStart could also
fail and lead to the same situation (TransferShedder will constantly make
UnloadDecision(fail))
Yes, the lazy initialization in validateTableViewStart could also fail, but
it will not fail forever. If we only caught the exception, it will fail forever.
> I can update the code for option 1 (retry-forever).
I think it's ok, we can merge it first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
