Demogorgon314 commented on code in PR #19773:
URL: https://github.com/apache/pulsar/pull/19773#discussion_r1136423905
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateData.java:
##########
@@ -27,7 +29,8 @@
*/
public record ServiceUnitStateData(
- ServiceUnitState state, String dstBroker, String sourceBroker, boolean
force, long timestamp, long versionId) {
+ ServiceUnitState state, String dstBroker, String sourceBroker,
+ Map<String, Optional<String>> splitServiceUnitToDestBroker, boolean
force, long timestamp, long versionId) {
Review Comment:
> Don't we need to keep the order of boundaries? Can it be a List?
No, we don't need to keep the order of boundaries. Yes, it can be a list,
but it cannot be duplicated.
> Can you explain why we have the dstBroker value? Can we remove the
dstBroker?
Do we need to assign the sub bundle directly to a dst broker and unload the
parent bundle? If we need this feature, it can be impl in the future.
> Currently, I think we only require split boundaries. Can we make it
List<Long> splitBoundaries?
If we need to support sub bundles direct assign, then we need to keep the
map.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
