merlimat commented on code in PR #19817:
URL: https://github.com/apache/pulsar/pull/19817#discussion_r1137429475


##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/coordination/impl/ResourceLockImpl.java:
##########
@@ -71,7 +72,20 @@ public synchronized T getValue() {
 
     @Override
     public synchronized CompletableFuture<Void> updateValue(T newValue) {
-       return acquire(newValue);
+        // If there is an operation in progress, we're going to let it 
complete before attempting to
+        // update the value
+        pendingOperationFuture = pendingOperationFuture.thenCompose(v -> {

Review Comment:
   That's correct, I think we're missing to reset it once it gets completed 
once.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to