alpreu opened a new pull request, #19836: URL: https://github.com/apache/pulsar/pull/19836
### Motivation Currently, there is an inconsistency between sinks and sources. Sinks can be created by passing the whole config in the sinkConfig file: ``` ./bin/pulsar-admin sinks create --sink-config-file <file-name>.yaml ``` But Sources cannot. If we do the equivalent: ``` ./bin/pulsar-admin sources create --source-config-file <file-name>.yaml >Source archive not specified ``` To make it work, we currently have to explicitly pass in the type parameter: ``` ./bin/pulsar-admin sources create --source-config-file <file-name>.yaml --source-type foo ``` ### Modifications Add the `sourceType` to `SourceConfig` so it can be passed through the config file too. ### Verifying this change - [ ] Make sure that the change passes the CI checks. This change added tests and can be verified as follows: - extended `TestCmdSources` ### Does this pull request potentially affect one of the following parts: <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [x] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc` <!-- Your PR contains doc changes. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [x] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> ### Matching PR in forked repository PR in forked repository: https://github.com/alpreu/pulsar/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
