sag-tjegorow opened a new pull request, #351:
URL: https://github.com/apache/pulsar-helm-chart/pull/351

   Adds the ability to configure anti-affinity topology key.
   
   ### Motivation
   
   Ability to set custom anti-affinity topology key should make it easier to 
use pulsar-helm-charts in a high availability multi-AZ cluster (we can use 
zone/region topology key). Also custom topology will allow the use of keys that 
are non-standard/not-well-known (see 
https://kubernetes.io/docs/reference/labels-annotations-taints/), the example 
being "topology.ebs.csi.aws.com/zone`" from EBS (see 
https://github.com/kubernetes-sigs/aws-ebs-csi-driver/issues/729), or just 
being deprecated (like "failure-domain.beta.kubernetes.io/zone") but still used 
on older k8s clusters.
   
   I realize there are already 2 PRs waiting for the acceptance that kind of do 
the same thing:
   * https://github.com/apache/pulsar-helm-chart/pull/61 -- at this moment it 
is a bit stale as it was created in September 2020 (and there are more other 
changes/refactorings).
   * https://github.com/apache/pulsar-helm-chart/pull/127 -- functionally very 
similar to this one (except soft affinity weight configuration) but does not 
allow to configure custom topology key. Being able to configure the topology 
key makes this PR simpler.
   
   ### Modifications
   
   Just the ability to configure topology keys using new values: 
<component>.affinity.anti_affinity_topology_key -- defaults to currently 
hard-coded "kubernetes.io/hostname".
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to