lhotari commented on code in PR #19830:
URL: https://github.com/apache/pulsar/pull/19830#discussion_r1139089884
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/AuthorizationService.java:
##########
@@ -331,7 +327,9 @@ public boolean isValidOriginalPrincipal(String
authenticatedPrincipal,
}
} else if (StringUtils.isNotBlank(originalPrincipal)
&& !(allowNonProxyPrincipalsToBeEqual &&
originalPrincipal.equals(authenticatedPrincipal))) {
- errorMsg = "cannot specify originalPrincipal when connecting
without valid proxy role.";
+ log.warn("[{}] Non-proxy role [{}] passed originalPrincipal
[{}]. This behavior will not "
Review Comment:
I think it's justified to log a warning since it's a true warning about
invalid usage. The Pulsar admin should react and fix the invalid usage to get
rid of the warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
