michaeljmarshall opened a new pull request, #19845:
URL: https://github.com/apache/pulsar/pull/19845

   Relates to: #19455 #19830
   
   ### Motivation
   
   When I added the requirement for the proxy to use a role in the `proxyRoles` 
set, I didn't add a test that checked the negative case. This new test was 
first added in #19830 with one small difference. The goal of this test is to 
ensure that authorization of the client role and the original role is handled 
correctly.
   
   ### Modifications
   
   * Add new test class named `AuthorizationServiceTest`. We use `pass.proxy` 
and `fail.proxy` as proxy roles to simulate cases where the proxy's role passes 
and fails authorization, which is always possible.
   * Add new mock authorization provider named `MockAuthorizationProvider`. The 
logic is to let any role that starts with `pass` be considered authorized.
   
   ### Verifying this change
   
   This is a new test. It simply verifies the existing behavior to prevent 
future regressions.
   
   ### Documentation
   
   - [x] `doc-not-needed`
   
   ### Matching PR in forked repository
   
   PR in forked repository: Skipping forked test since the new tests pass 
locally and there are no other modifications.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to