[GitHub] [pulsar] poorbarcode commented on a diff in pull request #18010: [improve] [broker] make consumer and producer can work even if schema ledger lost

Fri, 17 Mar 2023 10:20:34 -0700 


poorbarcode commented on code in PR #18010:
URL: https://github.com/apache/pulsar/pull/18010#discussion_r1140505643


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/BookkeeperSchemaStorage.java:
##########
@@ -691,7 +691,8 @@ public static Exception bkException(String operation, int 
rc, long ledgerId, lon
             message += " - entry=" + entryId;
         }
         boolean recoverable = rc != 
BKException.Code.NoSuchLedgerExistsException
-                && rc != BKException.Code.NoSuchEntryException;
+                && rc != BKException.Code.NoSuchEntryException
+                && rc != 
BKException.Code.NoSuchLedgerExistsOnMetadataServerException;

Review Comment:
   Yes. We will check the config `autoSkipNonRecoverableData` when the 
BKException has been caught. Such as this case: 
   <img width="772" alt="截屏2023-03-18 01 19 11" 
src="https://user-images.githubusercontent.com/25195800/225974613-16aee2d3-7217-457d-aaf5-a41889c5e588.png";>
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to