This is an automated email from the ASF dual-hosted git repository.
zike pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 1e44ba179bf [fix][doc] The `messageIds` in `onNegativeAcksSend`
shouldn't be null (#19852)
1e44ba179bf is described below
commit 1e44ba179bfc189d22dff046a1887e12842b0851
Author: Zike Yang <[email protected]>
AuthorDate: Tue Mar 21 16:17:41 2023 +0800
[fix][doc] The `messageIds` in `onNegativeAcksSend` shouldn't be null
(#19852)
### Motivation
The `onNegativeAcksSend` is only called by:
https://github.com/apache/pulsar/blob/80c5791b87482bee3392308ecef45f455f8de885/pulsar-client/src/main/java/org/apache/pulsar/client/impl/NegativeAcksTracker.java#L83
It will not be null. The statement `null if acknowledge fail.` is incorrect.
### Modifications
* Remove the incorrect statement and refine the doc.
Signed-off-by: Zike Yang <[email protected]>
Co-authored-by: Jun Ma <[email protected]>
---
.../src/main/java/org/apache/pulsar/client/api/ConsumerInterceptor.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerInterceptor.java
b/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerInterceptor.java
index d6d91cd8850..be2f9b0f108 100644
---
a/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerInterceptor.java
+++
b/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerInterceptor.java
@@ -107,7 +107,7 @@ public interface ConsumerInterceptor<T> extends
AutoCloseable {
* <p>Any exception thrown by this method will be ignored by the caller.
*
* @param consumer the consumer which contains the interceptor
- * @param messageIds message to ack, null if acknowledge fail.
+ * @param messageIds the set of message ids to negatively ack
*/
void onNegativeAcksSend(Consumer<T> consumer, Set<MessageId> messageIds);
