Technoboy- commented on code in PR #19875:
URL: https://github.com/apache/pulsar/pull/19875#discussion_r1143245493
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java:
##########
@@ -240,7 +240,9 @@ protected void updateTopicPolicy(TopicPolicies data) {
topicPolicies.getDispatchRate().updateTopicValue(DispatchRateImpl.normalize(data.getDispatchRate()));
topicPolicies.getSchemaValidationEnforced().updateTopicValue(data.getSchemaValidationEnforced());
topicPolicies.getEntryFilters().updateTopicValue(data.getEntryFilters());
- this.subscriptionPolicies = data.getSubscriptionPolicies();
+ if (data.getSubscriptionPolicies() != null) {
Review Comment:
`subscriptionPolicies` shouldn't be null, only `updateTopicPolicy ` may
change it, so I think it's better to modify line-243.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
