mattisonchao commented on code in PR #19858:
URL: https://github.com/apache/pulsar/pull/19858#discussion_r1143424835
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java:
##########
@@ -1050,7 +1050,19 @@ public CompletableFuture<Void> closeAsync() {
});
}
- return closeFuture;
+ return closeFuture.thenCompose(ignore -> {
+ if (retryLetterProducer != null){
+ return retryLetterProducer.closeAsync();
Review Comment:
Should we close them parallelly? Do you think we should make some special
exception handling here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
