BewareMyPower commented on code in PR #984:
URL: https://github.com/apache/pulsar-client-go/pull/984#discussion_r1145803096
##########
pulsar/error.go:
##########
@@ -103,14 +107,8 @@ const (
ProducerClosed
// SchemaFailure means the payload could not be encoded using the Schema
SchemaFailure
-
- // ReachMaxPendingOps means the pending operations in transaction_impl
coordinator reach the maximum.
- ReachMaxPendingOps
// InvalidStatus means the component status is not as expected.
InvalidStatus
- // TransactionError means this is a transaction related error
- TransactionError
-
Review Comment:
Just a note here: it's a breaking change. But these error codes were added
in http://github.com/apache/pulsar-client-go/pull/953, which is not included in
any official release yet. So it's okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]