RobertIndie commented on code in PR #231:
URL: https://github.com/apache/pulsar-client-cpp/pull/231#discussion_r1147187456
##########
tests/InterceptorsTest.cc:
##########
@@ -272,8 +273,11 @@ class ConsumerTestInterceptor : public ConsumerInterceptor
{
class ConsumerInterceptorsTest : public
::testing::TestWithParam<std::tuple<TopicType, int>> {
public:
void SetUp() override {
- topic_ =
"persistent://public/default/InterceptorsTest-ConsumerInterceptors-" +
- std::to_string(time(nullptr));
Review Comment:
Using `GetParam()` couldn't solve the issue. Multiple tests share the same
params. If we want to splice `GetParam()`, we also need to splice the `current
test method` name. But this PR seems simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
