StevenLuMT commented on code in PR #19926:
URL: https://github.com/apache/pulsar/pull/19926#discussion_r1149170227
##########
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceProducer.java:
##########
@@ -479,6 +479,19 @@ public static void main(String[] args) throws Exception {
oldTime = now;
}
+ executorShutdownNow();
+ }
+
+ static void executorShutdownNow() {
Review Comment:
> Can you elaborate a bit why we need to explicitly shutdown the executor?
If the process exits, all tasks just halted.
I think it's more elegant to actively close, control the shutdown wait time,
If the main thread exits, the thread may run incomplete @tisonkun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
