momo-jun commented on code in PR #493:
URL: https://github.com/apache/pulsar-site/pull/493#discussion_r1150112037
##########
docs/admin-api-brokers.md:
##########
@@ -87,39 +69,53 @@ Fetch the information of the leader broker, for example,
the service url.
<TabItem value="pulsar-admin">
```shell
-pulsar-admin brokers leader-broker
+pulsar-admin brokers namespaces use \
+ --url localhost:8080
```
Example output:
-```json
-{
- "serviceUrl" : "http://localhost:8080";
-}
+```
+public/default/0x00000000_0x40000000 [broker_assignment=shared
is_controlled=false is_active=true]
+public/default/0xc0000000_0xffffffff [broker_assignment=shared
is_controlled=false is_active=true]
+public/functions/0x40000000_0x80000000 [broker_assignment=shared
is_controlled=false is_active=true]
+public/functions/0x00000000_0x40000000 [broker_assignment=shared
is_controlled=false is_active=true]
+pulsar/standalone/localhost:8080/0x00000000_0xffffffff
[broker_assignment=shared is_controlled=false is_active=true]
+pulsar/localhost:8080/0x00000000_0xffffffff [broker_assignment=shared
is_controlled=false is_active=true]
+public/functions/0x80000000_0xc0000000 [broker_assignment=shared
is_controlled=false is_active=true]
+public/default/0x80000000_0xc0000000 [broker_assignment=shared
is_controlled=false is_active=true]
```
</TabItem>
<TabItem value="REST API">
-{@inject:
endpoint|GET|/admin/v2/brokers/leaderBroker|operation/getLeaderBroker?version=@pulsar:version_number@}
+{@inject:
endpoint|GET|/admin/v2/brokers/:cluster/:broker/ownedNamespaces|operation/getOwnedNamespaes?version=@pulsar:version_number@}
</TabItem>
<TabItem value="Java">
```java
-admin.brokers().getLeaderBroker()
+admin.brokers().getOwnedNamespaces(cluster,brokerUrl);
```
-For the detail of the code above, see
[here](https://github.com/apache/pulsar/blob/master/pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/BrokersImpl.java#L80)
-
</TabItem>
</Tabs>
````
-#### list of namespaces owned by a given broker
+## Update broker conf
+
+You can update broker configurations using one of the following ways:
-It finds all namespaces which are owned and served by a given broker.
+- Supply
[configurations](https://pulsar.apache.org/reference/#/@pulsar:version_origin@/config/reference-configuration-broker)
when starting up brokers.
+
+- [Update configurations dynamically](#update-broker-conf-dynamically) **when
running brokers**.
+
+ Since all broker configurations in Pulsar are stored in ZooKeeper,
configuration values can also be dynamically updated when brokers are running.
When you update broker configurations dynamically, ZooKeeper will notify the
broker of the change and then the broker will override any existing
configuration values.
+
+### List updatable broker conf
Review Comment:
It seems more like an optional step before users dynamically update broker
conf. The same applies to `List updated broker conf`. Logically, they are
talking about the `list` feature, not `update`, but can be leveraged
before/after updating broker conf.
So I suggest a tweak on heading 2 and heading 3, using either of the
following.
**OptionA:**
```
## List updatable broker conf
...
## List updated broker conf
...
## Update broker conf dynamically
... // link to the the List headings
```
**OptionB:**
```
## Update broker conf dynamically
1. List updatable broker conf
2. ...
3. List updated broker conf
```
The difference between A and B is whether we want to highlight the feature
of `list`. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
