BewareMyPower commented on code in PR #232:
URL: https://github.com/apache/pulsar-client-cpp/pull/232#discussion_r1150707299
##########
lib/AckGroupingTracker.cc:
##########
@@ -62,25 +74,39 @@ static std::ostream& operator<<(std::ostream& os, const
std::set<MessageId>& msg
return os;
}
-bool AckGroupingTracker::doImmediateAck(ClientConnectionWeakPtr connWeakPtr,
uint64_t consumerId,
- const std::set<MessageId>& msgIds) {
- auto cnx = connWeakPtr.lock();
- if (cnx == nullptr) {
- LOG_DEBUG("Connection is not ready, ACK failed.");
- return false;
+void AckGroupingTracker::doImmediateAck(const std::set<MessageId>& msgIds,
ResultCallback callback) const {
+ const auto cnx = connectionSupplier_();
+ if (!cnx) {
+ LOG_DEBUG("Connection is not ready, ACK failed for " << msgIds);
+ if (callback) {
+ callback(ResultAlreadyClosed);
+ }
+ return;
}
if
(Commands::peerSupportsMultiMessageAcknowledgement(cnx->getServerProtocolVersion()))
{
- auto cmd = Commands::newMultiMessageAck(consumerId, msgIds);
- cnx->sendCommand(cmd);
- LOG_DEBUG("ACK request is sent for " << msgIds.size() << " messages: "
<< msgIds);
+ if (waitResponse_) {
+ const auto requestId = requestIdSupplier_();
+ cnx->sendRequestWithId(Commands::newMultiMessageAck(consumerId_,
msgIds, requestId), requestId)
+ .addListener([callback](Result result, const ResponseData&) {
+ if (callback) {
+ callback(result);
+ }
+ });
+ } else {
+ cnx->sendCommand(Commands::newMultiMessageAck(consumerId_,
msgIds));
Review Comment:
Yes. I wrote a bug in the latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
