coderzc commented on code in PR #19716:
URL: https://github.com/apache/pulsar/pull/19716#discussion_r1151662444
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BookkeeperBucketSnapshotStorage.java:
##########
@@ -212,8 +208,8 @@ private CompletableFuture<Void> addEntry(LedgerHandle
ledgerHandle, byte[] data)
});
}
- CompletableFuture<Enumeration<LedgerEntry>>
getLedgerEntryThenCloseLedger(LedgerHandle ledger,
-
long firstEntryId, long lastEntryId) {
+ CompletableFuture<Enumeration<LedgerEntry>> getLedgerEntry(LedgerHandle
ledger,
Review Comment:
Ledger is already closed after `createBucketSnapshot`, so we don't need to
close it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
