horizonzy commented on code in PR #19913:
URL: https://github.com/apache/pulsar/pull/19913#discussion_r1152699146
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/LedgerOffloaderFactory.java:
##########
@@ -42,20 +42,39 @@
boolean isDriverSupported(String driverName);
/**
- * Create a ledger offloader with the provided configuration,
user-metadata and scheduler.
+ * Create a ledger offloader with the provided configuration,
user-metadata, scheduler and offloaderStats.
*
* @param offloadPolicies offload policies
* @param userMetadata user metadata
* @param scheduler scheduler
* @return the offloader instance
* @throws IOException when fail to create an offloader
*/
+ default T create(OffloadPoliciesImpl offloadPolicies,
+ Map<String, String> userMetadata,
+ OrderedScheduler scheduler)
+ throws IOException {
+ return create(offloadPolicies, userMetadata, scheduler, null);
Review Comment:
Thanks for your reminder. Here we shouldn't make the method default. This
method won't invoke in pulsar directly. In the pulsar master branch, it only
invokes the method with the param `offloaderStats`. This method is compatible
with the nar package, let the user implements by themselves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
