315157973 commented on code in PR #19972:
URL: https://github.com/apache/pulsar/pull/19972#discussion_r1154054493
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -338,7 +338,38 @@ public CompletableFuture<Void> initialize() {
if (cursor.getName().startsWith(replicatorPrefix)) {
String localCluster =
brokerService.pulsar().getConfiguration().getClusterName();
String remoteCluster =
PersistentReplicator.getRemoteCluster(cursor.getName());
- futures.add(addReplicationCluster(remoteCluster, cursor,
localCluster));
+ final CompletableFuture<Void> future = new
CompletableFuture<>();
+ addReplicationCluster(remoteCluster, cursor,
localCluster).whenComplete((__, e) -> {
+ if (e == null) {
+ future.complete(null);
+ } else {
+ Throwable throwable = e;
+ while (throwable.getCause() != null) {
+ throwable = throwable.getCause();
+ }
+ if (throwable instanceof
MetadataStoreException.NotFoundException
+ &&
throwable.getMessage().equals(remoteCluster)) {
+ log.warn("[{}] Remote cluster '{}' is not found
while there is a replicator cursor,"
+ + " remove cursor '{}'", topic,
remoteCluster, cursor.getName());
+ ledger.asyncDeleteCursor(cursor.getName(), new
DeleteCursorCallback() {
Review Comment:
How do we make sure we don't delete by mistake?
1. If there is a situation such as jitter, which makes the data temporarily
unobtainable, will there be accidental deletion?
2. Will cursors be lost if the remote cluster is briefly unavailable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
