crossoverJie commented on PR #19967:
URL: https://github.com/apache/pulsar/pull/19967#issuecomment-1492801690

   > This comment is correct but seems redundant - it adds no extra info from 
my perspective.
   
   
![image](https://user-images.githubusercontent.com/15684156/229261509-74228ee6-0152-49b5-8d17-20c7ee2b3874.png)
   
   From the purpose of this PR, it is to provide a way to obtain the real IP 
address, but using the "real" keyword in `proxy.conf` cannot find this 
configuration, and the current description of haProxyProtocolEnabled is also 
unclear about its relation to "real IP". **Unless one looks at the source code, 
it may be difficult to quickly locate this configuration**, so I believe adding 
a description would be helpful.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to