mattisonchao commented on code in PR #19737:
URL: https://github.com/apache/pulsar/pull/19737#discussion_r1155314101
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -429,6 +431,25 @@ public AtomicLong getPendingWriteOps() {
return pendingWriteOps;
}
+ public CompletableFuture<Void> unloadSubscription(String subName) {
+ final PersistentSubscription sub = subscriptions.get(subName);
+ if (sub == null) {
+ return CompletableFuture.failedFuture(new
RestException(Response.Status.NOT_FOUND,
Review Comment:
>It is better to redesign the exception when there is another requirement to
call this method。
Since Apache Pulsar is an open-source project, suppose you hand over this
responsibility to the next contributor. The odds are that he will simply use
this exception. This will create a large amount of technical debt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
