RobertIndie commented on code in PR #20009:
URL: https://github.com/apache/pulsar/pull/20009#discussion_r1157173099
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java:
##########
@@ -252,6 +254,8 @@ public ClientCnx(ClientConfigurationData conf,
EventLoopGroup eventLoopGroup, in
this.state = State.None;
this.protocolVersion = protocolVersion;
this.idleState = new ClientCnxIdleState(this);
+ this.clientVersion = "Pulsar-Java-v" + PulsarVersion.getVersion()
+ + (conf.getDescription() == null ? "" : conf.getDescription());
Review Comment:
According to the PIP and the method description document:
> For example, if the client version is 3.0.0, and the description is
"forked", the final client version string
> * will be "Pulsar-Java-v3.0.0-forked".
We need a middle '-' here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
