shibd opened a new pull request, #310:
URL: https://github.com/apache/pulsar-client-node/pull/310

   Fixes #283 
   
   ### Motivation
   
   The root cause is the OpenSSL symbol conflict between Node.js and CPP client.
   
   In versions after Node.js 17 or greater, the OpenSSL version was upgraded to 
3.0.0, and the cpp client used v1.1.1 of Openssl. 
   
   Therefore, it results in a segmentation fault when users use TLS-related 
features.
   
   ### Modifications
   - When building `pulsar.node`, use `"-Wl,--exclude-libs,ALL"` config to 
hidden symbol.
   
   
   ### Verifying this change
   
   You can use this [repo](https://github.com/shibd/pulsar-client-tls-test.git) 
to verify it.
   
   I have verified that the environment has:
   
   Image:
   - node:16
   - node:16-alpine
   - node:17
   - node:17-alpine
   - node:18
   - node:18-alpine
   - node:19
   - node:19-alpine
   
   BTW: I will add tls-relate unit test in subsequent PR.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
   
   - [x] `doc-not-needed` 
   (Please explain why)
   
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to