BewareMyPower commented on code in PR #230:
URL: https://github.com/apache/pulsar-client-cpp/pull/230#discussion_r1159902706
##########
include/pulsar/c/consumer_configuration.h:
##########
@@ -304,6 +304,28 @@ PULSAR_PUBLIC void
pulsar_consumer_configuration_set_start_message_id_inclusive(
PULSAR_PUBLIC int pulsar_consumer_configuration_is_start_message_id_inclusive(
pulsar_consumer_configuration_t *consumer_configuration);
+/**
+ * Set batch receive policy.
+ *
+ * The default value: {maxNumMessage: -1, maxNumBytes: 10 * 1024 * 1024,
timeoutMs: 100}
+ * @param consumer_configuration the consumer conf object.
+ * @param maxNumMessage default: Max num message, if less than 0, it means no
limit.
+ * @param maxNumBytes Max num bytes, if less than 0, it means no limit.
+ * @param timeoutMs If less than 0, it means no limit.
+ */
+PULSAR_PUBLIC void pulsar_consumer_configuration_set_batch_receive_policy(
+ pulsar_consumer_configuration_t *consumer_configuration, int
maxNumMessage, long maxNumBytes,
+ long timeoutMs);
+
+PULSAR_PUBLIC int
pulsar_consumer_configuration_get_batch_receive_policy_max_num_message(
+ pulsar_consumer_configuration_t *consumer_configuration);
+
+PULSAR_PUBLIC long
pulsar_consumer_configuration_get_batch_receive_policy_max_num_bytes(
+ pulsar_consumer_configuration_t *consumer_configuration);
+
+PULSAR_PUBLIC long
pulsar_consumer_configuration_get_batch_receive_policy_timeout_ms(
+ pulsar_consumer_configuration_t *consumer_configuration);
Review Comment:
It might be better to define a struct that represents the batch receive
policy to avoid too many setters.
```c
typedef struct {
int maxNumMessage;
int maxNumBytes;
long timeoutMs;
} pulsar_batch_receive_policy_t;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
