AnonHxy commented on code in PR #20001:
URL: https://github.com/apache/pulsar/pull/20001#discussion_r1161046362
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/metrics/ManagedLedgerMetrics.java:
##########
@@ -108,6 +108,8 @@ private List<Metrics> aggregate(Map<Metrics,
List<ManagedLedgerImpl>> ledgersByD
(double) lStats.getReadEntriesErrors());
populateAggregationMapWithSum(tempAggregatedMetricsMap,
"brk_ml_ReadEntriesRate",
lStats.getReadEntriesRate());
+ populateAggregationMapWithSum(tempAggregatedMetricsMap,
"brk_ml_ReadEntriesOpsCacheMissesRate",
+ lStats.getReadEntriesOpsCacheMissesRate());
Review Comment:
> Why didn't this go with the other cache metrics?
>
I think that it's more reasonable that here It follows the style of other
`ManagedLedgerMetrics`, like `brk_ml_ReadEntriesRate` and so on. They all are
aggregation by namespace, not aggregation by ledger.
In other place we go with the well know format, like
`pulsar_storage_read_cache_misses_rate` and
`pulsar_broker_storage_read_cache_misses_rate`
https://github.com/apache/pulsar/pull/20001/files#diff-79bde2a6feed80b6b6b4b6950bc7d4ccd93946a8ec0b40cc1bef2e7b3e498f21R155-R157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
