yyj8 opened a new pull request, #20048:
URL: https://github.com/apache/pulsar/pull/20048

   ### Motivation
   In the current topic level monitoring, there is no metrics to monitor the 
number of send data requests and the number of messages per send request (i.e., 
each entry) for a topic. This is inconvenient for us to troubleshoot the 
following issues:
   
   1. In cases where the client does not perform batch data writing or the 
batch written messages are not very reasonable, we cannot intuitively reflect 
through monitoring and cannot detect unreasonable business usage in a timely 
manner; It has a significant impact on production and consumption performance, 
increasing cluster load, reducing cluster performance, and increasing overall 
costs;
   
   2. When we enable the production flow limiting strategy, if the flow 
limiting condition is triggered by the number of requests on a single 
connection, it is difficult to accurately locate which topic's high-frequency 
send data is causing it;
   
   ### Modifications
   Add four metrics:
   `pulsar_request_rate_in`: Topic send request rate.
   `pulsar_average_msg_per_request`: Average number of messages per send 
request for topic.
   
   `pulsar_producer_request_in`: producer send request rate.
   `pulsar_producer_avg_msg_per_request`: Average number of messages per send 
request for producer.
   
   ### Does this pull request potentially affect one of the following parts:
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   *If the box was checked, please highlight the changes*
   
   - [ ] Dependencies (add or upgrade a dependency)
   - [ ] The public API
   - [ ] The schema
   - [ ] The default values of configurations
   - [ ] The threading model
   - [ ] The binary protocol
   - [ ] The REST endpoints
   - [ ] The admin CLI options
   - [x] The metrics
   - [ ] Anything that affects deployment
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [x] `doc-required` <!-- Your PR changes impact docs and you will update 
later -->
   - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   PR in forked repository: https://github.com/yyj8/pulsar/pull/6<!-- ENTER URL 
HERE -->
   
   <!--
   After opening this PR, the build in apache/pulsar will fail and instructions 
will
   be provided for opening a PR in the PR author's forked repository.
   
   apache/pulsar pull requests should be first tested in your own fork since 
the 
   apache/pulsar CI based on GitHub Actions has constrained resources and quota.
   GitHub Actions provides separate quota for pull requests that are executed 
in 
   a forked repository.
   
   The tests will be run in the forked repository until all PR review comments 
have
   been handled, the tests pass and the PR is approved by a reviewer.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to