coderzc commented on code in PR #20031:
URL: https://github.com/apache/pulsar/pull/20031#discussion_r1161472533


##########
conf/pulsar_tools_env.sh:
##########
@@ -42,6 +42,18 @@
 # PULSAR_GLOBAL_ZK_CONF=
 
 # Extra options to be passed to the jvm
+# Discard parameter "-Xms" of $PULSAR_MEM, which tends to be the Broker's 
minimum memory, to avoid using too much
+# memory by tools.
+if [ -n "$PULSAR_MEM" ]; then
+  PULSAR_MEM_REWRITE="-Xmx128m -XX:MaxDirectMemorySize=128m"

Review Comment:
   We can just remove the `-Xms`, `-Xmx` and `-XX:MaxDirectMemorySize` don't 
need overriding to 128m



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to