RobertIndie commented on code in PR #309:
URL:
https://github.com/apache/pulsar-client-node/pull/309#discussion_r1161600987
##########
src/Consumer.cc:
##########
@@ -55,21 +56,34 @@ void Consumer::Init(Napi::Env env, Napi::Object exports) {
struct MessageListenerProxyData {
std::shared_ptr<pulsar_message_t> cMessage;
Consumer *consumer;
+ std::function<void(void)> callback;
- MessageListenerProxyData(std::shared_ptr<pulsar_message_t> cMessage,
Consumer *consumer)
- : cMessage(cMessage), consumer(consumer) {}
+ MessageListenerProxyData(std::shared_ptr<pulsar_message_t> cMessage,
Consumer *consumer,
+ std::function<void(void)> callback)
+ : cMessage(cMessage), consumer(consumer), callback(callback) {}
};
void MessageListenerProxy(Napi::Env env, Napi::Function jsCallback,
MessageListenerProxyData *data) {
Napi::Object msg = Message::NewInstance({}, data->cMessage);
Consumer *consumer = data->consumer;
- delete data;
Review Comment:
So from my understanding, we shouldn't `delete data` here. Right? Otherwise,
it will result in double deletion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
