codelipenghui commented on code in PR #20040:
URL: https://github.com/apache/pulsar/pull/20040#discussion_r1161682487
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Consumer.java:
##########
@@ -536,19 +537,38 @@ CompletableFuture<Void>
reconsumeLaterCumulativeAsync(Message<?> message,
CompletableFuture<Void> seekAsync(long timestamp);
/**
- * Get the last message id available for consume.
+ * Get the last message id of the topic subscribed.
*
- * @return the last message id.
+ * @return the last message id of the topic subscribed
+ * @throws PulsarClientException if multiple topics or partitioned topics
are subscribed or failed because of a
+ * network issue
+ * NOTE: Use {@link Consumer#getLastMessageIds()} instead.
*/
+ @Deprecated
Review Comment:
I think we should keep the test until we remove the API. Otherwise, we might
introduce breaking changes to the deprecated API in the subsequent releases,
maybe a patch release of the LTS version. The deprecated API should also be
under the guarantee until it is removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
