chrisjohnson00 commented on PR #356: URL: https://github.com/apache/pulsar-helm-chart/pull/356#issuecomment-1502215114
> > Oh, I hadn't noticed that both the service and the deployment shared these values. Wouldn't this make it a breaking change since the service ports would change? I'd be happy to update it so it is not a BC! > > Sorry for my delayed response. Yes, it would make it a breaking change. It'd be great if we can avoid the breaking change, thanks! I've pushed up a change that makes this backward compatible. Let me know what you think. I've introduced using named ports for the `targetPort` in the service, which helps to further protect future change from being breaking. Since the port names in the service and stateful set were the same, I prefixed the ports in the sts with `sts-` to distinguish them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
