nlu90 commented on code in PR #20000:
URL: https://github.com/apache/pulsar/pull/20000#discussion_r1163056808
##########
pulsar-function-go/conf/conf.go:
##########
@@ -50,15 +50,17 @@ type Conf struct {
SecretsMap string `json:"secretsMap" yaml:"secretsMap"`
Runtime int32 `json:"runtime" yaml:"runtime"`
//Deprecated
- AutoACK bool `json:"autoAck" yaml:"autoAck"`
- Parallelism int32 `json:"parallelism" yaml:"parallelism"`
+ AutoACK bool `json:"autoAck" yaml:"autoAck"`
+ Parallelism int32 `json:"parallelism" yaml:"parallelism"`
//source config
SubscriptionType int32 `json:"subscriptionType"
yaml:"subscriptionType"`
TimeoutMs uint64 `json:"timeoutMs" yaml:"timeoutMs"`
SubscriptionName string `json:"subscriptionName"
yaml:"subscriptionName"`
CleanupSubscription bool `json:"cleanupSubscription"
yaml:"cleanupSubscription"`
SubscriptionPosition int32 `json:"subscriptionPosition"
yaml:"subscriptionPosition"`
//source input specs
+ SourceInputSpecs map[string]string `json:"sourceInputSpecs"
yaml:"sourceInputSpecs"`
+ // for backward compatibility
SourceSpecTopic string `json:"sourceSpecsTopic"
yaml:"sourceSpecsTopic"`
SourceSchemaType string `json:"sourceSchemaType"
yaml:"sourceSchemaType"`
Review Comment:
you should mark `Deprecated` for fields that's not intended for use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
