rdhabalia commented on code in PR #19414: URL: https://github.com/apache/pulsar/pull/19414#discussion_r1163636407
########## pulsar-client-api/src/main/java/org/apache/pulsar/client/api/MessageIdAdv.java: ########## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.client.api; + +import java.util.BitSet; + +/** + * The {@link MessageId} interface provided for advanced users. + * <p> + * All built-in MessageId implementations should be able to be cast to MessageIdAdv. + * </p> + */ +public interface MessageIdAdv extends MessageId { + + /** + * Get the ledger ID. + * + * @return the ledger ID + */ + long getLedgerId(); Review Comment: > When users need to access the detailed fields, they should have assumed the storage is BookKeeper. That's an absolutely wrong assumption and they must not do it. MessageId is just a reference-id to Pulsar and it's nothing related to BookKeeper. it took a huge effort to get rid of zookeeper dependency and should not do the same with any public API. > It's an ideal assumption. In real world, there are a lot of code references that use ledgerId/entryId from the MessageId. As I mentioned earlier, MessageId is a Pulsar reference and no one should extract any information from MessageId and depend on it. And this PR, exactly does the opposite and encourages users to extract and depend on it. We don't want to pay price for user dependency on such an invalid contract and can't make any changes in Pulsar later on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
