gaoran10 commented on code in PR #20030:
URL: https://github.com/apache/pulsar/pull/20030#discussion_r1164508455
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java:
##########
@@ -157,8 +158,7 @@ public String authenticate(AuthenticationDataSource
authData) throws Authenticat
AuthenticationMetrics.authenticateSuccess(getClass().getSimpleName(),
getAuthMethodName());
return role;
} catch (AuthenticationException exception) {
-
AuthenticationMetrics.authenticateFailure(getClass().getSimpleName(),
getAuthMethodName(),
- exception.getMessage());
+
AuthenticationMetrics.authenticateFailure(getClass().getSimpleName(),
getAuthMethodName(), exception);
Review Comment:
It seems it's hard to find a unified entrance to increment the
authentication metric. Maybe we can try to improve this in another PR. WDYT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
