freeznet commented on PR #19975: URL: https://github.com/apache/pulsar/pull/19975#issuecomment-1506361412
@michaeljmarshall I noticed that this PR changed the interface of the functions worker's API, such changes should be avoided to cherry-pick into the historical branches. As for the APIs changes, it requires a PIP first, then adopting the implementation to the codebase, see https://github.com/apache/pulsar/blob/master/wiki/proposals/PIP.md#when-is-a-pip-required. It should be better to revert this PR first, send the PIP to the community, and then get the implementation to the codebase, WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
