tisonkun commented on code in PR #20100:
URL: https://github.com/apache/pulsar/pull/20100#discussion_r1166504628
##########
pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchConfig.java:
##########
@@ -242,6 +242,11 @@ public class ElasticSearchConfig implements Serializable {
)
private String primaryFields = "";
+ @FieldDoc(
+ required = false,
+ defaultValue = "",
+ help = "The SSL config for elastic search."
+ )
private ElasticSearchSslConfig ssl = new ElasticSearchSslConfig();
Review Comment:
Nested configs should be supported to generate configs properly. But I'd
like to postpone it to a follow-up. Printing an empty string doesn't hurt and
no regression here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
