onobc commented on code in PR #124:
URL: 
https://github.com/apache/pulsar-client-reactive/pull/124#discussion_r1167740189


##########
pulsar-client-reactive-adapter/build.gradle:
##########
@@ -37,6 +37,7 @@ dependencies {
        testImplementation libs.mockito.inline
 
        intTestImplementation 
project(':pulsar-client-reactive-producer-cache-caffeine')
+       intTestImplementation project(path: 
':pulsar-client-reactive-producer-cache-caffeine-shaded', configuration: 
'shadow')

Review Comment:
   So this is interesting, bringing in both shaded and non-shaded. This is to 
allow the intTest to use both shaded and non-shaded to make sure all is working 
well in both. 
   
   It also means there are 2 service providers on the classpath for 
`ProducerCacheProviderFactory` (shaded and non-shaded). This is ok as we simply 
use the 1st one we encounter which happens to be the non-shaded version and all 
the intTests work fine as long as this is true. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to