heesung-sn commented on code in PR #20110:
URL: https://github.com/apache/pulsar/pull/20110#discussion_r1167958485


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java:
##########
@@ -819,7 +819,7 @@ private CompletableFuture<Integer> closeServiceUnit(String 
serviceUnit) {
         NamespaceBundle bundle = getNamespaceBundle(serviceUnit);
         return pulsar.getBrokerService().unloadServiceUnit(
                         bundle,
-                        false,

Review Comment:
   I checked the original unload behavior, and it is set to true. I think we 
need to follow the existing unload behavior. Please correct me if I am wrong 
here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to