BewareMyPower opened a new pull request, #253: URL: https://github.com/apache/pulsar-client-cpp/pull/253
### Motivation The C++ catch up of [PIP-254](https://github.com/apache/pulsar/issues/19705) ### Modifications Different from the Java implementation, this PR adds private methods to set or get the description in `ClientConfiguration`. Since `PulsarWrapper` is used as a friend class of nearly all public classes, the 3rd party library that is based on the C++ SDK can set the description by defining a `PulsarWrapper` class. For the `ConnectionPool` and any `ClientConnection` instance created, store the client version and pass it into `Commands::newConnect`. Modify the `ClientTest.testClientVersion` to verify the changes. ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc-required` (Your PR needs to update docs and you will update later) - [ ] `doc-not-needed` (Please explain why) - [x] `doc` (Your PR contains doc changes) - [ ] `doc-complete` (Docs have been already added) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
