tisonkun commented on code in PR #20096:
URL: https://github.com/apache/pulsar/pull/20096#discussion_r1169412700
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -3066,21 +3068,25 @@ boolean shouldCloseLedger(LedgerHandle lh) {
}
}
- void switchToNewLedger(final LedgerHandle lh, final VoidCallback callback)
{
+ void switchToNewLedger(@Nonnull LedgerHandle lh, VoidCallback callback) {
Review Comment:
`Nonnull` can be default and I second that we don't have to add `Nonnull`
here and there, but the place where it is critical and we hope the IDE hint
possibly null inputs.
So, either we add `@Nonnull` for `callback` also, or just close this PR and
also the original issue since there's no efficient issue anymore. What do you
think @BewareMyPower ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
