mattisonchao commented on code in PR #20122:
URL: https://github.com/apache/pulsar/pull/20122#discussion_r1169475919
##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/ZKSessionWatcher.java:
##########
@@ -81,7 +83,8 @@ public void close() throws Exception {
}
// task that runs every TICK_TIME to check zk connection
- private synchronized void checkConnectionStatus() {
+ @VisibleForTesting
+ private void checkConnectionStatus() {
Review Comment:
if zk client can't ensure the order. We should add a comment to explain this
method is not thread-safe. because we call it in the single thread, it will be
fine. but we shouldn't leave any potential problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
